Wyatt-FOSS/wyatt-packages
Wyatt-FOSS/wyatt-packages
6
2
Fork 0
Code Issues 20 Pull Requests 3 Actions Packages Projects Releases Activity

ui_kit/feat/button-components #134

Merged
hugo merged 35 commits from ui_kit/feat/button-components into master 2023-02-16 08:58:03 +00:00
Conversation 4 Commits 35 Files Changed 114 +5734 -182
hugo commented 2023-02-10 13:51:06 +00:00
Owner
Copy Link
  • FlatButton (plain/outlined)
  • SymbolButton (selectable)
  • SimpleIconButton (force icon child)
  • FileSelectionButton (can be invalid)
- [x] FlatButton (plain/outlined) - [x] SymbolButton (selectable) - [x] SimpleIconButton (force icon child) - [x] FileSelectionButton (can be invalid)
hugo force-pushed ui_kit/feat/button-components from c5e9259adc to 15ad037d47 2023-02-10 16:02:57 +00:00 Compare
hugo force-pushed ui_kit/feat/button-components from 881c8c9190 to 4695cf0618 2023-02-14 10:58:01 +00:00 Compare
hugo added 2 commits 2023-02-14 11:50:55 +00:00
hugo commented 2023-02-14 11:51:49 +00:00
Author
Owner
Copy Link

Move carousel_controller in another issue/pr because of his anatomy:

  • multiple buttons
  • controller (not only UI)
Move carousel_controller in another issue/pr because of his anatomy: - multiple buttons - controller (not only UI)
hugo changed title from WIP: ui_kit/feat/button-components to ui_kit/feat/button-components 2023-02-14 11:52:14 +00:00
hugo changed title from ui_kit/feat/button-components to WIP: ui_kit/feat/button-components 2023-02-14 11:52:50 +00:00
hugo commented 2023-02-14 11:53:36 +00:00
Author
Owner
Copy Link
  • need to add ThemeExtension support
  • enhance example with light/dark mode support
- need to add ThemeExtension support - enhance example with light/dark mode support
hugo added 1 commit 2023-02-14 13:21:44 +00:00
hugo force-pushed ui_kit/feat/button-components from 1703e5b4d0 to 198d83b663 2023-02-14 13:48:19 +00:00 Compare
hugo added 1 commit 2023-02-14 13:49:46 +00:00
hugo added 5 commits 2023-02-15 14:58:24 +00:00
hugo added 1 commit 2023-02-15 19:14:42 +00:00
hugo added 3 commits 2023-02-15 20:45:58 +00:00
hugo added 2 commits 2023-02-15 21:36:34 +00:00
hugo changed title from WIP: ui_kit/feat/button-components to ui_kit/feat/button-components 2023-02-15 21:37:18 +00:00
hugo added 1 commit 2023-02-15 21:40:26 +00:00
style(ui_kit): fix padding file selection
Some checks failed
continuous-integration/drone/push Build is failing
Details
3a7b0abc58
malo approved these changes 2023-02-16 08:46:23 +00:00
malo commented 2023-02-16 08:54:26 +00:00
Owner
Copy Link

Too many files to comment in the review :

  • Abstract text_resolver is very cool 👍 👍
  • Unless I'm mistaken, the style function override loses the styles calculated in the previous function. The abstract logic seems good, maybe review the switch case in the style_resolver implementations ?
  • Resolve function should be private in screen files ?
  • Export bloc should be seperate widget instead of method helper in mixin ?
Too many files to comment in the review : - Abstract text_resolver is very cool 👍 👍 - Unless I'm mistaken, the style function override loses the styles calculated in the previous function. The abstract logic seems good, maybe review the switch case in the style_resolver implementations ? - Resolve function should be private in screen files ? - Export bloc should be seperate widget instead of method helper in mixin ?
❤️ 1
hugo merged commit 3a7b0abc58 into master 2023-02-16 08:58:03 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
malo
Labels
Clear labels
package
all
Related to all package
package
analysis
package
architecture
package
authentication
package
bloc_helper
package
bloc_layout
package
component_copy_with
package
crud
package
form
package
http
package
i18n
package
notification
package
proposal
New package proposal
package
type_utils
package
ui_components
package
ui_kit
package
ui_layout
assets
Related to assets
breaking
Breaking changes.
bug
Unexpected problem or unintended behavior
build
Related to build
config
Related to configuration
dependencies
Update dependencies
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
invalid
This doesn't seem right
logic
Related to business logic.
needs review
Needs review
next
In next major release/milestone
priority
critical
The priority is critical
priority
high
The priority is high
priority
low
The priority is low
priority
medium
The priority is medium
proposal
Proposal for new feature or request. Need discussion.
question
Further information is requested
refactor
Refactoring code
run
Related to runtime.
test
Related to tests
ui
Related to user interface.
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
alex angele.perraudin hugo malo mathieu.dejeans parfait.tapsoba.007
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Wyatt-FOSS/wyatt-packages#134
No description provided.
Delete Branch "ui_kit/feat/button-components"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?