Wyatt-FOSS/wyatt-packages
Wyatt-FOSS/wyatt-packages
6
2
Fork 0
Code Issues 20 Pull Requests 4 Actions Packages Projects Releases Activity

authentication/feature/google_signin #105

Merged
malo merged 7 commits from authentication/feature/google_signin into master 2022-12-13 22:07:17 +00:00
Conversation 2 Commits 7 Files Changed 56 +503 -310
hugo commented 2022-12-13 16:12:10 +00:00
Owner
Copy Link
No description provided.
hugo added 5 commits 2022-12-13 16:12:10 +00:00
malo requested changes 2022-12-13 16:33:34 +00:00
packages/wyatt_authentication_bloc/lib/src/data/data_sources/remote/authentication_firebase_data_source_impl.dart Outdated
@ -185,0 +206,4 @@
_latestCreds = userCredential;
final user = userCredential.user;
if (user.isNotNull) {
return _mapper(user!);
malo commented 2022-12-13 16:25:06 +00:00
Owner
Copy Link

Maybe parsing the data into a model should be the responsibility of the model, not the data source?

Maybe add fromFirebaseUser(..) parser method to AccountModel.

Maybe parsing the data into a model should be the responsibility of the model, not the data source? Maybe add `fromFirebaseUser(..)` parser method to `AccountModel`.
malo marked this conversation as resolved
hugo added 2 commits 2022-12-13 21:43:07 +00:00
clean(packages): apply dart fix (close #106)
All checks were successful
continuous-integration/drone/push Build is passing
Details
17ff0f8ba1
hugo added 1 commit 2022-12-13 22:00:33 +00:00
hugo requested review from malo 2022-12-13 22:00:50 +00:00
malo approved these changes 2022-12-13 22:06:17 +00:00
malo merged commit f22ba300cb into master 2022-12-13 22:07:17 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
malo
Labels
Clear labels
package
all
Related to all package
package
analysis
package
architecture
package
authentication
package
bloc_helper
package
bloc_layout
package
component_copy_with
package
crud
package
form
package
http
package
i18n
package
notification
package
proposal
New package proposal
package
type_utils
package
ui_components
package
ui_kit
package
ui_layout
assets
Related to assets
breaking
Breaking changes.
bug
Unexpected problem or unintended behavior
build
Related to build
config
Related to configuration
dependencies
Update dependencies
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
invalid
This doesn't seem right
logic
Related to business logic.
needs review
Needs review
next
In next major release/milestone
priority
critical
The priority is critical
priority
high
The priority is high
priority
low
The priority is low
priority
medium
The priority is medium
proposal
Proposal for new feature or request. Need discussion.
question
Further information is requested
refactor
Refactoring code
run
Related to runtime.
test
Related to tests
ui
Related to user interface.
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
alex angele.perraudin hugo malo mathieu.dejeans parfait.tapsoba.007
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Wyatt-FOSS/wyatt-packages#105
No description provided.
Delete Branch "authentication/feature/google_signin"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?