Wyatt-FOSS/wyatt-packages
Wyatt-FOSS/wyatt-packages
6
2
Fork 0
Code Issues 20 Pull Requests 3 Actions Packages Projects Releases Activity

Add custom lint rules #170

New Issue
Open
opened 2023-04-07 12:28:49 +00:00 by hugo · 1 comment
hugo commented 2023-04-07 12:28:49 +00:00
Owner
Copy Link
- Add them in wyatt_analysis ? Or maybe create new package wyatt_lint ? - Use https://github.com/invertase/dart_custom_lint - Need to discuss about team rules
hugo added the
package
proposal
config
proposal
 labels 2023-04-07 12:28:49 +00:00
hugo commented 2023-04-14 10:33:36 +00:00
Author
Owner
Copy Link

Rules proposition:

  • equatable
  • avoid_hardcoded_strings
  • naming convention ?
    • foo_repository / FooRepository for BaseRepository extends
    • foo_data_source / FooDataSource for Base[Remote/Local]DataSource extends
    • foo_[scope/type_]repository_impl for repository implementation
    • foo_[scope/type_]data_source_impl for data source implementation
    • foo_[consumer/provider_]screen for state management files
  • import ?
    • do not import data layer in domain
    • do not import data layer in presentation
      ...
Rules proposition: - equatable - always_call_super_props_when_overriding_equatable_props - missing_field_in_equatable_props - https://pub.dev/packages/equatable_lint - avoid_hardcoded_strings - naming convention ? - foo_repository / FooRepository for BaseRepository extends - foo_data_source / FooDataSource for Base[Remote/Local]DataSource extends - foo_[scope/type_]repository_impl for repository implementation - foo_[scope/type_]data_source_impl for data source implementation - foo_[consumer/provider_]screen for state management files - import ? - do not import data layer in domain - do not import data layer in presentation ...
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
package
all
Related to all package
package
analysis
package
architecture
package
authentication
package
bloc_helper
package
bloc_layout
package
component_copy_with
package
crud
package
form
package
http
package
i18n
package
notification
package
proposal
New package proposal
package
type_utils
package
ui_components
package
ui_kit
package
ui_layout
assets
Related to assets
breaking
Breaking changes.
bug
Unexpected problem or unintended behavior
build
Related to build
config
Related to configuration
dependencies
Update dependencies
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
invalid
This doesn't seem right
logic
Related to business logic.
needs review
Needs review
next
In next major release/milestone
priority
critical
The priority is critical
priority
high
The priority is high
priority
low
The priority is low
priority
medium
The priority is medium
proposal
Proposal for new feature or request. Need discussion.
question
Further information is requested
refactor
Refactoring code
run
Related to runtime.
test
Related to tests
ui
Related to user interface.
wontfix
This will not be worked on
No Label
package
proposal
config
proposal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
alex angele.perraudin hugo malo mathieu.dejeans parfait.tapsoba.007
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Wyatt-FOSS/wyatt-packages#170
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?