From 83216cbbbb73c5764f130d34bfc2aa321c55e904 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Malo=20L=C3=A9on?= Date: Mon, 15 May 2023 18:27:20 +0200 Subject: [PATCH] style: Improved error message consistency --- .../fastlane/plugin/ios_cd/actions/build_and_deploy_action.rb | 3 ++- .../lib/fastlane/plugin/ios_cd/helper/ios_cd_helper.rb | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/plugins/fastlane-plugin-ios_cd/lib/fastlane/plugin/ios_cd/actions/build_and_deploy_action.rb b/plugins/fastlane-plugin-ios_cd/lib/fastlane/plugin/ios_cd/actions/build_and_deploy_action.rb index 5e62d3a..5ed1345 100644 --- a/plugins/fastlane-plugin-ios_cd/lib/fastlane/plugin/ios_cd/actions/build_and_deploy_action.rb +++ b/plugins/fastlane-plugin-ios_cd/lib/fastlane/plugin/ios_cd/actions/build_and_deploy_action.rb @@ -5,9 +5,10 @@ module Fastlane module Actions class BuildAndDeployAction < Action def self.run(params) + # Check parameters unless Helper::IosCdHelper.is_set(params[:beta_type]) - UI.error("❌ Parameters beta_type cannot be null") + UI.user_error("❌ Parameters beta_type cannot be null") puts("Error on beta type parameter") end diff --git a/plugins/fastlane-plugin-ios_cd/lib/fastlane/plugin/ios_cd/helper/ios_cd_helper.rb b/plugins/fastlane-plugin-ios_cd/lib/fastlane/plugin/ios_cd/helper/ios_cd_helper.rb index 68853ce..d183935 100644 --- a/plugins/fastlane-plugin-ios_cd/lib/fastlane/plugin/ios_cd/helper/ios_cd_helper.rb +++ b/plugins/fastlane-plugin-ios_cd/lib/fastlane/plugin/ios_cd/helper/ios_cd_helper.rb @@ -26,7 +26,7 @@ module Fastlane # Move the extracted files to the current directory `jar xvf #{ios_directory}/ios_keys.zip && mv #{ios_directory}/ios_keys/* #{ios_directory}` else - puts("Erreur lors de la décompression du fichier GPG") + UI.user_error("❌ Erreur lors de la décompression du fichier GPG") end end @@ -38,7 +38,7 @@ module Fastlane JSON.parse(file) else - UI.error("❌ Ios credentials doesn't exist") + UI.user_error("❌ Ios credentials doesn't exist") puts("json file doesn't exist") end end -- 2.47.2