From a9557fbc516db914325a8439f528c31713b94570 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Malo=20L=C3=A9on?= Date: Mon, 15 May 2023 19:34:10 +0200 Subject: [PATCH] refactor: user_error fn --- .../actions/build_and_deploy_action.rb | 16 ++++++++-------- .../plugin/android_cd/actions/promote_action.rb | 4 ++-- .../android_cd/helper/android_cd_helper.rb | 2 +- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/plugins/fastlane-plugin-android_cd/lib/fastlane/plugin/android_cd/actions/build_and_deploy_action.rb b/plugins/fastlane-plugin-android_cd/lib/fastlane/plugin/android_cd/actions/build_and_deploy_action.rb index 53f9935..731aed1 100644 --- a/plugins/fastlane-plugin-android_cd/lib/fastlane/plugin/android_cd/actions/build_and_deploy_action.rb +++ b/plugins/fastlane-plugin-android_cd/lib/fastlane/plugin/android_cd/actions/build_and_deploy_action.rb @@ -7,7 +7,7 @@ module Fastlane def self.run(params) # Check parameters unless Helper::AndroidCdHelper.is_set(params[:beta_type]) - UI.user_error("❌ Parameters beta_type cannot be null") + UI.user_error!("❌ Parameters beta_type cannot be null") puts("Error on beta type parameter") end @@ -24,13 +24,13 @@ module Fastlane # Build the Android App Bundle other_action.gradle( - task: "bundle", - build_type: "Release", - print_command: true, - properties: { - "android.injected.version.code" => build_number - } - )) + task: "bundle", + build_type: "Release", + print_command: true, + properties: { + "android.injected.version.code" => build_number + } + ) # Upload the Android App Bundle to the Play Store other_action.upload_to_play_store( diff --git a/plugins/fastlane-plugin-android_cd/lib/fastlane/plugin/android_cd/actions/promote_action.rb b/plugins/fastlane-plugin-android_cd/lib/fastlane/plugin/android_cd/actions/promote_action.rb index 403bcfd..5188e41 100644 --- a/plugins/fastlane-plugin-android_cd/lib/fastlane/plugin/android_cd/actions/promote_action.rb +++ b/plugins/fastlane-plugin-android_cd/lib/fastlane/plugin/android_cd/actions/promote_action.rb @@ -7,12 +7,12 @@ module Fastlane def self.run(params) # Check from parameters unless Helper::AndroidCdHelper.is_set(params[:from]) - UI.user_error("❌ Parameters from cannot be null") + UI.user_error!("❌ Parameters from cannot be null") end # Check destination parameters unless Helper::AndroidCdHelper.is_set(params[:destination]) - UI.user_error("❌ Parameters destination cannot be null") + UI.user_error!("❌ Parameters destination cannot be null") end UI.message("⌛️ Promoting to Google Play Store from #{params[:from]} to #{params[:destination]}..") diff --git a/plugins/fastlane-plugin-android_cd/lib/fastlane/plugin/android_cd/helper/android_cd_helper.rb b/plugins/fastlane-plugin-android_cd/lib/fastlane/plugin/android_cd/helper/android_cd_helper.rb index 438c74d..9921246 100644 --- a/plugins/fastlane-plugin-android_cd/lib/fastlane/plugin/android_cd/helper/android_cd_helper.rb +++ b/plugins/fastlane-plugin-android_cd/lib/fastlane/plugin/android_cd/helper/android_cd_helper.rb @@ -17,7 +17,7 @@ module Fastlane # Move the extracted files to the current directory `jar xvf #{android_directory} && mv #{android_directory}/android_keys/* #{android_directory}` else - UI.user_error("❌ Erreur lors de la décompression du fichier GPG") + UI.user_error!("❌ Erreur lors de la décompression du fichier GPG") end end